Messages in this thread | | | Subject | Re: [PATCH v3 00/12] cros_ec: Match licenses and switch to SPDX identifier. | From | Joe Perches <> | Date | Wed, 06 Jun 2018 08:42:19 -0700 |
| |
On Wed, 2018-06-06 at 17:08 +0200, Enric Balletbo i Serra wrote: > Dear all, > > This patchset is just to adopt the SPDX license identifier for all > ChromeOS Embedded Controller related drivers.
This bit is fine,
> The patches touches > different subsystems but every patch can be picked from their respective > maintainer independently. > > This third version takes the license note as the valid license (I did > the contrary in the second version) so apart from add the SPDX tags it > also introduces new patches to match the license.
But why change any MODULE_LICENSE text?
There are uses of MODULE_LICENSE("GPL") where the SPDX license identifier is some GPL variant
For instance: $ git grep -P --name-only 'MODULE_LICENSE\s*\("GPL"\s*\)\s*;'| \ xargs grep "SPDX-License- Identifier:" | \ cut -f3- -d: | \ sed -r 's@\s*\*/\s*$@@' | \ sort | uniq -c | sort -rn 551 GPL-2.0+ 281 GPL-2.0 13 GPL-1.0+ 9 GPL-2.0-only 2 GPL-2.0 OR MIT 1 (GPL-2.0 OR MPL-1.1) 1 (GPL-2.0+ OR BSD-3-Clause) 1 (GPL-2.0 OR BSD-3-Clause)
And if you were to do this, please do it tree-wide, and ideally via a script
| |