[lkml]   [2018]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 1/7] atomics/tty: add missing atomic_long_t * cast
On Tue, Jun 05, 2018 at 04:53:34PM +0200, Peter Zijlstra wrote:
> On Tue, Jun 05, 2018 at 04:43:04PM +0200, Peter Zijlstra wrote:
> > I can make a proper patch, hold on.
> ---
> Subject: atomic/tty: Fix up atomic abuse in ldsem
> Mark found ldsem_cmpxchg() needed an (atomic_long_t *) cast to keep
> working after making the atomic_long interface type safe.
> Needing casts is bad form, which made me look at the code. There are no
> ld_semaphore::count users outside of these functions so there is no
> reason why it can not be an atomic_long_t in the first place, obviating
> the need for this cast.
> That also ensures the loads use atomic_long_read(), which implies (at
> least) READ_ONCE() in order to guarantee single-copy-atomic loads.
> When using atomic_long_try_cmpxchg() the ldsem_cmpxchg() wrapper gets
> very thin (the only difference is not changing *old on success, which
> most callers don't seem to care about).
> So rework the whole thing to use atomic_long_t and its accessors
> directly.
> While there, fixup all the horrible comment styles.
> Cc: Peter Hurley <>
> Reported-by: Mark Rutland <>
> Signed-off-by: Peter Zijlstra (Intel) <>

Looks good, I'll queue this up after 4.18-rc1 is out, thanks.

greg k-h

 \ /
  Last update: 2018-06-06 16:01    [W:0.107 / U:10.952 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site