lkml.org 
[lkml]   [2018]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
Subjectunnecessary tests?
In the file drivers/media/tuners/mxl5005s.c, the function MXL_BlockInit
contains:

status += MXL_ControlWrite(fe,
RFSYN_EN_CHP_HIGAIN, state->Mode ? 1 : 1);
status += MXL_ControlWrite(fe, EN_CHP_LIN_B, state->Mode ? 0 : 0);

Could the second arguments just be 1 and 0, respectively? It's true that
the preceeding call contains state->Mode, but in a more useful way, so
perhaps it could be useful for uniformity?

thanks,
julia

\
 
 \ /
  Last update: 2018-06-06 14:42    [W:0.017 / U:6.008 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site