lkml.org 
[lkml]   [2018]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 3/8] x86/apic: Provide apic_ack_irq()
On Wed, 6 Jun 2018, Dou Liyang wrote:

> Hi Thomas,
>
> At 06/05/2018 07:41 PM, Thomas Gleixner wrote:
> > On Tue, 5 Jun 2018, Dou Liyang wrote:
> > > > +{
> > > > + if (unlikely(irqd_is_setaffinity_pending(irqd)))
> > >
> > > Affinity pending is also judged in
> > >
> > > > + irq_move_irq(irqd);
> > >
> > > If we can remove the if(...) statement here
> >
> > That requires to fix all call sites in ia64 and that's why I didn't. But
>
> I didn't express clearly, I meant remove the if(...) statement from
> apic_ack_irq(), it doesn't require to fix the call sites in ia64.

I put the check there on purpose as I explained in the changelog:

Making the invocation of irq_move_irq() conditional avoids the out of
line call if the pending bit is not set.

Thanks,

tglx

\
 
 \ /
  Last update: 2018-06-06 10:05    [W:0.031 / U:3.136 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site