lkml.org 
[lkml]   [2018]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] slab: Clean up the code comment in slab kmem_cache struct
On Sun, 3 Jun 2018, Baoquan He wrote:

> diff --git a/include/linux/slab_def.h b/include/linux/slab_def.h
> index d9228e4d0320..3485c58cfd1c 100644
> --- a/include/linux/slab_def.h
> +++ b/include/linux/slab_def.h
> @@ -67,9 +67,10 @@ struct kmem_cache {
>
> /*
> * If debugging is enabled, then the allocator can add additional
> - * fields and/or padding to every object. size contains the total
> - * object size including these internal fields, the following two
> - * variables contain the offset to the user object and its size.
> + * fields and/or padding to every object. 'size' contains the total
> + * object size including these internal fields, while 'obj_offset'
> + * and 'object_size' contain the offset to the user object and its
> + * size.
> */
> int obj_offset;
> #endif /* CONFIG_DEBUG_SLAB */
>

Wish we had some more consistent naming. object_size and obj_offset??? And
the fields better be as close together as possible.


Acked-by: Christoph Lameter <cl@linux.com>

\
 
 \ /
  Last update: 2018-06-05 19:24    [W:0.075 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site