lkml.org 
[lkml]   [2018]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3]: perf record: enable arbitrary event names thru name= modifier
Em Tue, Jun 05, 2018 at 09:00:17AM +0300, Alexey Budankov escreveu:
> Hi,
> On 04.06.2018 22:16, Arnaldo Carvalho de Melo wrote:
> > Em Mon, Jun 04, 2018 at 06:22:43PM +0300, Alexey Budankov escreveu:
> >> On 04.06.2018 17:58, Arnaldo Carvalho de Melo wrote:
> >>> Em Mon, Jun 04, 2018 at 05:51:03PM +0300, Alexey Budankov escreveu:
> >>>> event names quoted there. If such cases were pointed out then they also
> >>>> could be addressed along with the unit/regression testing mentioned above.
> >
> >>> So lests stick to just the unit/regression testing, can you take a look
> >>> at that?
> >
> >> Sure. Is it enough to run perf record with some quoted event name to make
> >> sure it runs successfully?
> >
> > I mentioned tools/perf/tests/attr/, for checking if the perf_event_attr
> > was setup the way you intended, and tools/perf/tests/parse-events.c,
> > which probably is what we want here, see, for instance, this cset I've
> > added recently to have we testing intel_pt event parsing:
> >
> > $ git show b3f58c8da64bc63bd0c0a06a4e2cf258a3d20be6
> > commit b3f58c8da64bc63bd0c0a06a4e2cf258a3d20be6
> > Author: Arnaldo Carvalho de Melo <acme@redhat.com>
> > Date: Fri May 11 11:48:54 2018 -0300
> >
> > perf tests parse-events: Add intel_pt parse test
> >
> > To avoid regressions such as the one fixed by 4a35a9027f64 ("Revert
> > "perf pmu: Fix pmu events parsing rule""), where '-e intel_pt//u' got
> > broken, with this new entry in this 'perf tests' subtest, we would have
> > caught it before pushing upstream.
> >
> > Acked-by: Jiri Olsa <jolsa@kernel.org>
> > Cc: Adrian Hunter <adrian.hunter@intel.com>
> > Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
> > Cc: Andi Kleen <ak@linux.intel.com>
> > Cc: David Ahern <dsahern@gmail.com>
> > Cc: Jiri Olsa <jolsa@kernel.org>
> > Cc: Kan Liang <kan.liang@linux.intel.com>
> > Cc: Namhyung Kim <namhyung@kernel.org>
> > Cc: Peter Zijlstra <peterz@infradead.org>
> > Cc: Wang Nan <wangnan0@huawei.com>
> > Link: https://lkml.kernel.org/n/tip-kw62fys9bwdgsp722so2ln1l@git.kernel.org
> > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> >
> > diff --git a/tools/perf/tests/parse-events.c b/tools/perf/tests/parse-events.c
> > index 18b06444f230..6829dd416a99 100644
> > --- a/tools/perf/tests/parse-events.c
> > +++ b/tools/perf/tests/parse-events.c
> > @@ -1309,6 +1309,14 @@ static int test__checkevent_config_cache(struct perf_evlist *evlist)
> > return 0;
> > }
> >
> > +static int test__intel_pt(struct perf_evlist *evlist)
> > +{
> > + struct perf_evsel *evsel = perf_evlist__first(evlist);
> > +
> > + TEST_ASSERT_VAL("wrong name setting", strcmp(evsel->name, "intel_pt//u") == 0);
> > + return 0;
> > +}
> > +
> > static int count_tracepoints(void)
> > {
> > struct dirent *events_ent;
> > @@ -1637,6 +1645,11 @@ static struct evlist_test test__events[] = {
> > .check = test__checkevent_config_cache,
> > .id = 51,
> > },
> > + {
> > + .name = "intel_pt//u",
> > + .check = test__intel_pt,
> > + .id = 52,
> > + },
> > };
> >
> > static struct evlist_test test__events_pmu[] = {
> >
> > See also this one:
> >
> > static int
> > test__checkevent_breakpoint_len_rw_modifier(struct perf_evlist *evlist)
> > {
> > struct perf_evsel *evsel = perf_evlist__first(evlist);
> >
> > TEST_ASSERT_VAL("wrong exclude_user", !evsel->attr.exclude_user);
> > TEST_ASSERT_VAL("wrong exclude_kernel", evsel->attr.exclude_kernel);
> > TEST_ASSERT_VAL("wrong exclude_hv", evsel->attr.exclude_hv);
> > TEST_ASSERT_VAL("wrong precise_ip", !evsel->attr.precise_ip);
> >
> > return test__checkevent_breakpoint_rw(evlist);
> > }
> > {
> > .name = "mem:0/4:rw:u",
> > .check = test__checkevent_breakpoint_len_rw_modifier,
> > .id = 44
> > },
> >
> >
> > I.e. have as many TEST_ASSERT_VAL as you need, checking how parsing the
> > event name ends up setting up the evsel, evlist and perf_event_attr.
>
> Ok, I see. But please expect delay in delivery since I am on vacations till 06/18.

np.

- Arnaldo

\
 
 \ /
  Last update: 2018-06-05 17:33    [W:0.031 / U:12.668 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site