lkml.org 
[lkml]   [2018]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [greybus-dev] [PATCH] Staging:greybus Fix comparison to NULL
From
Date
On 06/05/2018 04:00 AM, Dan Carpenter wrote:
> On Tue, Jun 05, 2018 at 11:02:36AM +0530, Viresh Kumar wrote:
>> On 03-06-18, 08:52, Janani Sankara Babu wrote:
>>> This patch replaces comparison of var to NULL with !var
>>>
>>> Signed-off-by: Janani Sankara Babu <jananis37@gmail.com>

Wow, such deep discussion for such a trivial patch!

I say we take it, mostly because I personally prefer being
permissive if there's nothing technically wrong with a patch,
but also because I'm swayed by the other comments.

That being said, I agree with Johan--the patch would be
improved with a little better comment about what motivated
the submission. So I'll wait for v2.

-Alex

>>> ---
>>> drivers/staging/greybus/core.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/staging/greybus/core.c b/drivers/staging/greybus/core.c
>>> index dafa430..5d14a4e 100644
>>> --- a/drivers/staging/greybus/core.c
>>> +++ b/drivers/staging/greybus/core.c
>>> @@ -48,7 +48,7 @@ static bool greybus_match_one_id(struct gb_bundle *bundle,
>>> static const struct greybus_bundle_id *
>>> greybus_match_id(struct gb_bundle *bundle, const struct greybus_bundle_id *id)
>>> {
>>> - if (id == NULL)
>>> + if (!id)
>>
>> It is pretty much personal preference and there is no good reason to accept this
>> patch really.
>
> Checkpatch complains, so it's Official Kernel Style now.
>
> The != NULL comparison is a double negative which makes it not less
> annoying than official kernel style.
>
> regards,
> dan carpenter
>
> _______________________________________________
> greybus-dev mailing list
> greybus-dev@lists.linaro.org
> https://lists.linaro.org/mailman/listinfo/greybus-dev
>

\
 
 \ /
  Last update: 2018-06-05 14:37    [W:0.040 / U:29.764 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site