lkml.org 
[lkml]   [2018]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v1] clk: tegra: emc: Avoid out-of-bounds bug
    Date
    Apparently there was an attempt to avoid out-of-bounds accesses when there
    is only one memory timing available, but there is a typo in the code that
    neglects that attempt.

    Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
    ---
    drivers/clk/tegra/clk-emc.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/clk/tegra/clk-emc.c b/drivers/clk/tegra/clk-emc.c
    index 5234acd30e89..0621a3a82ea6 100644
    --- a/drivers/clk/tegra/clk-emc.c
    +++ b/drivers/clk/tegra/clk-emc.c
    @@ -132,7 +132,7 @@ static int emc_determine_rate(struct clk_hw *hw, struct clk_rate_request *req)
    timing = tegra->timings + i;

    if (timing->rate > req->max_rate) {
    - i = min(i, 1);
    + i = max(i, 1);
    req->rate = tegra->timings[i - 1].rate;
    return 0;
    }
    --
    2.17.0
    \
     
     \ /
      Last update: 2018-06-05 14:14    [W:4.909 / U:0.492 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site