lkml.org 
[lkml]   [2018]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v5] block: add verifier for cmdline partition
Date
ACK.

the patch is OK for me

> -----Original Message-----
> From: Wang YanQing [mailto:udknight@gmail.com]
> Sent: Tuesday, June 05, 2018 5:39 PM
> To: axboe@kernel.dk; gregkh@linuxfoundation.org;
> pombredanne@nexb.com; tglx@linutronix.de; Caizhiyong
> <caizhiyong@hisilicon.com>; rdunlap@infradead.org; Jiangheng
> <jiangheng@hisilicon.com>; linux-block@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH v5] block: add verifier for cmdline partition
>
> On Thu, May 10, 2018 at 11:06:37AM +0800, Wang YanQing wrote:
> > I meet strange filesystem corruption issue recently, the reason
> > is there are overlaps partitions in cmdline partition argument.
> >
> > This patch add verifier for cmdline partition, then if there are
> > overlaps partitions, cmdline_partition will log a warning. We don't
> > treat overlaps partition as a error:
> > "
> > Caizhiyong <caizhiyong@hisilicon.com> said:
> > Partition overlap was intentionally designed in this cmdline partition.
> > reference http://lists.infradead.org/pipermail/linux-mtd/2013-
> August/048092.html
> > "
> >
> > Signed-off-by: Wang YanQing <udknight@gmail.com>
> > ---
> > Changes
> > v4-v5:
> > 1:Delete unnecessary blank line at begin and end of logs.
> > 2:Delete newline character in log, pr_* will add newline
> > automatically.
> >
> > v3-v4:
> > 1:Fix grammar typo, reported by Randy Dunlap.
> > 2:Delete unnecessary type casting, reported by Caizhiyong.
> > 3:Record the reason why we can't treat overlapping partitions
> > as errors into changelog.
> >
> > v2-v3:
> > 1:Fix log one pair of overlaps partitions twice in cmdline_parts_verifier.
> > 2:Fix out of bound access in cmdline_parts_verifier.
> >
> > v1-v2:
> > 1:Don't treat overlaps partition as a error, but log a warning.
> >
> > Hi! Jens Axboe
> >
> > What is your suggestion?
> Hi! All
>
> I just want to know what is the status about this patch?
>
> ACK or NACK is welcome.
>
> Thanks

\
 
 \ /
  Last update: 2018-06-05 12:55    [W:0.021 / U:4.288 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site