lkml.org 
[lkml]   [2018]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V4] powercap/drivers/idle_injection: Add an idle injection framework
On 05-06-18, 08:53, Daniel Lezcano wrote:
> On 05/06/2018 07:53, Viresh Kumar wrote:
> > On 05-06-18, 07:48, Daniel Lezcano wrote:
> >> As soon as we reach complete(), no timer can be set because of the
> >> condition before.
> >
> > Why not ? We aren't using any locks here and it is possible that run_duration_ms
> > is set to 0 from idle_injection_stop() only after the first thread has restarted
> > the hrtimer. Isn't it ?
>
> If he restarted the timer, complete() won't be called and
> idle_injection_stop() will wait until the idle cycle injection is finished.

Obviously I missed that return statement within the conditional block :)

--
viresh

\
 
 \ /
  Last update: 2018-06-05 12:06    [W:0.032 / U:0.720 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site