Messages in this thread | | | Subject | Re: [PATCH v3 02/10] mfd: da9063: Use REGMAP_IRQ_REG | From | Marek Vasut <> | Date | Mon, 4 Jun 2018 18:23:59 +0200 |
| |
On 06/04/2018 02:26 PM, Lee Jones wrote: > On Sat, 02 Jun 2018, Marek Vasut wrote: > >> Convert the regmap_irq table to use REGMAP_IRQ_REG(). >> >> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> >> Cc: Geert Uytterhoeven <geert+renesas@glider.be> >> Cc: Lee Jones <lee.jones@linaro.org> >> Cc: Mark Brown <broonie@kernel.org> >> Cc: Steve Twiss <stwiss.opensource@diasemi.com> >> Cc: Wolfram Sang <wsa+renesas@sang-engineering.com> >> Cc: linux-renesas-soc@vger.kernel.org >> --- >> V3: New patch >> Note: A sed oneliner was used: >> sed -i "/\[DA9063_IRQ_/ {N;N;N;s/\n//g;s/.*\[\(DA9063_IRQ_[^]]\+\)].*reg_offset = \([^,]\+\),.* = \([^,]\+\),.*/\tREGMAP_IRQ_REG(\1, \2, \3),/}" drivers/mfd/da9063-irq.c >> --- >> drivers/mfd/da9063-irq.c | 145 ++++++++++------------------------------------- >> 1 file changed, 29 insertions(+), 116 deletions(-) >> >> diff --git a/drivers/mfd/da9063-irq.c b/drivers/mfd/da9063-irq.c >> index 207bbfe55449..5b406ecfc14a 100644 >> --- a/drivers/mfd/da9063-irq.c >> +++ b/drivers/mfd/da9063-irq.c >> @@ -28,125 +28,38 @@ >> >> static const struct regmap_irq da9063_irqs[] = { >> /* DA9063 event A register */ >> - [DA9063_IRQ_ONKEY] = { >> - .reg_offset = DA9063_REG_EVENT_A_OFFSET, >> - .mask = DA9063_M_ONKEY, >> - }, >> - [DA9063_IRQ_ALARM] = { >> - .reg_offset = DA9063_REG_EVENT_A_OFFSET, >> - .mask = DA9063_M_ALARM, >> - }, >> - [DA9063_IRQ_TICK] = { >> - .reg_offset = DA9063_REG_EVENT_A_OFFSET, >> - .mask = DA9063_M_TICK, >> - }, >> - [DA9063_IRQ_ADC_RDY] = { >> - .reg_offset = DA9063_REG_EVENT_A_OFFSET, >> - .mask = DA9063_M_ADC_RDY, >> - }, >> - [DA9063_IRQ_SEQ_RDY] = { >> - .reg_offset = DA9063_REG_EVENT_A_OFFSET, >> - .mask = DA9063_M_SEQ_RDY, >> - }, >> + REGMAP_IRQ_REG(DA9063_IRQ_ONKEY, DA9063_REG_EVENT_A_OFFSET, DA9063_M_ONKEY), >> + REGMAP_IRQ_REG(DA9063_IRQ_ALARM, DA9063_REG_EVENT_A_OFFSET, DA9063_M_ALARM), >> + REGMAP_IRQ_REG(DA9063_IRQ_TICK, DA9063_REG_EVENT_A_OFFSET, DA9063_M_TICK), >> + REGMAP_IRQ_REG(DA9063_IRQ_ADC_RDY, DA9063_REG_EVENT_A_OFFSET, DA9063_M_ADC_RDY), >> + REGMAP_IRQ_REG(DA9063_IRQ_SEQ_RDY, DA9063_REG_EVENT_A_OFFSET, DA9063_M_SEQ_RDY), > > Nice, but I think checkpatch.pl would complain. > > Better to break after the first argument I think.
Doesn't really help the readability, but done.
-- Best regards, Marek Vasut
| |