lkml.org 
[lkml]   [2018]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 4.4 08/56] ath10k: fix rfc1042 header retrieval in QCA4019 with eth decap mode
    From
    Date
    On Mon, 2018-05-14 at 08:48 +0200, Greg Kroah-Hartman wrote:
    > 4.4-stable review patch.  If anyone has any objections, please let me know.
    >
    > ------------------
    >
    > From: Vasanthakumar Thiagarajan <vthiagar@qti.qualcomm.com>
    >
    > commit 2f38c3c01de945234d23dd163e3528ccb413066d upstream.
    >
    > Chipset from QCA99X0 onwards (QCA99X0, QCA9984, QCA4019 & future)
    > rx_hdr_status is not padded to align in 4-byte boundary. Define a
    > new hw_params field to handle different alignment behaviour between
    > different hw. This patch fixes improper retrieval of rfc1042 header
    > with QCA4019. This patch along with "ath10k: Properly remove padding
    > from the start of rx payload" will fix traffic failure in ethernet
    > decap mode for QCA4019.
    >
    > Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@qti.qualcomm.com>
    > Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
    > Signed-off-by: Sriram R <srirrama@codeaurora.org>
    > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    [...]

    I'm curious as to why this backport doesn't include the change to
    ath10k_htt_rx_h_find_rfc1042(). I understand that the addition of the
    new field is a dependency for the following patch, but shouldn't the
    fix included in the upstream commit also be applied to 4.4?

    Ben.

    --
    Ben Hutchings, Software Developer   Codethink Ltd
    https://www.codethink.co.uk/ Dale House, 35 Dale Street
    Manchester, M1 2HF, United Kingdom

    \
     
     \ /
      Last update: 2018-06-04 19:52    [W:4.327 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site