lkml.org 
[lkml]   [2018]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH net] net: hns: Fix the process of adding broadcast addresses to tcam
Date
Hi Dave,
Thanks for pointing out. Will fix them.

Best regards
Salil

> -----Original Message-----
> From: David Miller [mailto:davem@davemloft.net]
> Sent: Monday, June 04, 2018 4:36 PM
> To: Salil Mehta <salil.mehta@huawei.com>
> Cc: Zhuangyuzeng (Yisen) <yisen.zhuang@huawei.com>; lipeng (Y)
> <lipeng321@huawei.com>; mehta.salil@opnsrc.net; netdev@vger.kernel.org;
> linux-kernel@vger.kernel.org; Linuxarm <linuxarm@huawei.com>; wangxi
> (M) <wangxi11@huawei.com>
> Subject: Re: [PATCH net] net: hns: Fix the process of adding broadcast
> addresses to tcam
>
> From: Salil Mehta <salil.mehta@huawei.com>
> Date: Fri, 1 Jun 2018 18:00:11 +0100
>
> > + hns_dsaf_setup_mc_mask(dsaf_dev, mac_entry->in_port_num,
> > + mc_mask, mac_entry->addr);
>
> Please indent things properly when arguments span multiple lines.
>
> The second line here should be precisely after the opennning
> parenthesis
> of the previous line.
>
> > + hns_dsaf_setup_mc_mask(dsaf_dev, mac_entry->in_port_num,
> > + mc_mask, mac_entry->addr);
>
> Likewise.

\
 
 \ /
  Last update: 2018-06-04 17:41    [W:0.043 / U:0.788 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site