lkml.org 
[lkml]   [2018]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 27/52] rtlwifi: rtl8192cu: Remove variable self-assignment in rf.c
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Matthias Kaehlcke <mka@chromium.org>

    commit fb239c1209bb0f0b4830cc72507cc2f2d63fadbd upstream.

    In _rtl92c_get_txpower_writeval_by_regulatory() the variable writeVal
    is assigned to itself in an if ... else statement, apparently only to
    document that the branch condition is handled and that a previously read
    value should be returned unmodified. The self-assignment causes clang to
    raise the following warning:

    drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c:304:13:
    error: explicitly assigning value of variable of type 'u32'
    (aka 'unsigned int') to itself [-Werror,-Wself-assign]
    writeVal = writeVal;

    Delete the branch with the self-assignment.

    Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
    Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
    Reviewed-by: Guenter Roeck <groeck@chromium.org>
    Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c | 3 ---
    1 file changed, 3 deletions(-)

    --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c
    +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c
    @@ -299,9 +299,6 @@ static void _rtl92c_get_txpower_writeval
    writeVal = 0x00000000;
    if (rtlpriv->dm.dynamic_txhighpower_lvl == TXHIGHPWRLEVEL_BT1)
    writeVal = writeVal - 0x06060606;
    - else if (rtlpriv->dm.dynamic_txhighpower_lvl ==
    - TXHIGHPWRLEVEL_BT2)
    - writeVal = writeVal;
    *(p_outwriteval + rf) = writeVal;
    }
    }

    \
     
     \ /
      Last update: 2018-06-04 09:27    [W:4.258 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site