lkml.org 
[lkml]   [2018]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [GIT PULL] x86/asm changes for v4.18
On Mon, Jun 4, 2018 at 5:21 AM Ingo Molnar <mingo@kernel.org> wrote:
>
> - __clear_user() micro-optimization (Alexey Dobriyan)

Was this actually tested?

I think one reason people avoided the constant was that on some
microarchitecture it ended up being a separate uop just for the
constant generation, because it wouldn't fit in a single uop.

I'm pretty sure that used to be the case for P4, for example.

Afaik there have also been issues with decoding instructions that have
both an immediate and a memory offset.

I suspect none of this is an issue on modern cores, but there really
at least historically were cases where

mov %reg,mem

was better than

mov $imm,mem

if %reg already had the right value, so it's not at all 100% obvious
that the micro-optimization really _optimizes_ anything.

Any time people do this, they should add numbers.

Linus

\
 
 \ /
  Last update: 2018-06-05 03:59    [W:0.066 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site