Messages in this thread | | | Date | Sat, 30 Jun 2018 20:19:17 +0900 (KST) | Subject | Re: [PATCH] net: cleanup gfp mask in alloc_skb_with_frags | From | David Miller <> |
| |
From: Michal Hocko <mhocko@kernel.org> Date: Thu, 28 Jun 2018 17:53:06 +0200
> From: Michal Hocko <mhocko@suse.com> > > alloc_skb_with_frags uses __GFP_NORETRY for non-sleeping allocations > which is just a noop and a little bit confusing. > > __GFP_NORETRY was added by ed98df3361f0 ("net: use __GFP_NORETRY for > high order allocations") to prevent from the OOM killer. Yet this was > not enough because fb05e7a89f50 ("net: don't wait for order-3 page > allocation") didn't want an excessive reclaim for non-costly orders > so it made it completely NOWAIT while it preserved __GFP_NORETRY in > place which is now redundant. > > Drop the pointless __GFP_NORETRY because this function is used as > copy&paste source for other places. > > Reviewed-by: Eric Dumazet <edumazet@google.com> > Signed-off-by: Michal Hocko <mhocko@suse.com>
Applied.
| |