lkml.org 
[lkml]   [2018]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 3/4] x86/split_lock: Handle #AC exception for split lock
On Fri, Jun 29, 2018 at 09:33:54AM -0700, Luck, Tony wrote:
> >> + WARN_ONCE(1, "A split lock issue is detected. Please FIX it\n");
> >
> > But, warning here is also not super useful. Shouldn't we be dumping out
> > the info in 'regs' instead of the current context? We don't care about
> > the state in the #AC handler, we care about 'regs'.

But WARN dump not only the state in the #AC handler, but also dump the regs
in the current context. And WARN dumps stack.

>
> Maybe:
>
> WARN_ONCE(1, "split lock detected at %pF\n", regs[EIP]);

Should we dump redundant regs info while WARN shows them all already?

Thanks.

-Fenghua

\
 
 \ /
  Last update: 2018-06-29 19:18    [W:0.085 / U:0.372 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site