lkml.org 
[lkml]   [2018]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH net-next 06/10] net: hns3: remove a redundant hclge_cmd_csq_done
    Date
    From: Huazhong Tan <tanhuazhong@huawei.com>

    Set complete in the first hclge_cmd_csq_done of hclge_cmd_send,
    and check if complete later, unnecessary to do hclge_cmd_csq_done
    again.

    Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
    Signed-off-by: Peng Li <lipeng321@huawei.com>
    ---
    drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.c | 12 ++++++------
    1 file changed, 6 insertions(+), 6 deletions(-)

    diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.c
    index 28556a9..facfff6 100644
    --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.c
    +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.c
    @@ -241,15 +241,18 @@ int hclge_cmd_send(struct hclge_hw *hw, struct hclge_desc *desc, int num)
    */
    if (HCLGE_SEND_SYNC(le16_to_cpu(desc->flag))) {
    do {
    - if (hclge_cmd_csq_done(hw))
    + if (hclge_cmd_csq_done(hw)) {
    + complete = true;
    break;
    + }
    udelay(1);
    timeout++;
    } while (timeout < hw->cmq.tx_timeout);
    }

    - if (hclge_cmd_csq_done(hw)) {
    - complete = true;
    + if (!complete) {
    + retval = -EAGAIN;
    + } else {
    handle = 0;
    while (handle < num) {
    /* Get the result of hardware write back */
    @@ -272,9 +275,6 @@ int hclge_cmd_send(struct hclge_hw *hw, struct hclge_desc *desc, int num)
    }
    }

    - if (!complete)
    - retval = -EAGAIN;
    -
    /* Clean the command send queue */
    handle = hclge_cmd_csq_clean(hw);
    if (handle != num) {
    --
    1.9.1
    \
     
     \ /
      Last update: 2018-06-29 12:58    [W:4.088 / U:0.996 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site