Messages in this thread | | | Subject | Re: [PATCH v3 1/5] clocksource/drivers/timer-mediatek: Add system timer bindings | From | Stanley Chu <> | Date | Fri, 29 Jun 2018 08:15:24 +0800 |
| |
On Thu, 2018-06-28 at 16:08 +0200, Daniel Lezcano wrote: > > +** System Timer (SYST) > > + > > +Required properties: > > +- compatible: Should contain > > + * "mediatek,mt6765-systimer" for MT6765 compatible timers > > +- reg: Should contain the location and length for system timer registers. > > +- clocks: System timer is drived by system clock. > > + > > +Examples: > > + > > + systimer@10017000 { > > + compatible = "mediatek,mt6765-systimer"; > > why not "mediatek,mt6765-timer" ? for consistency. > Hi Daniel,
The original thought is to remind user to notice that different timer will be used.
However it looks more clean if we use consistent name.
Will fix it in v4.
> > + reg = <0 0x10017000 0 0x1000>; > > + interrupts = <GIC_SPI 194 IRQ_TYPE_LEVEL_HIGH>; > > + clocks = <&system_clk>; > > }; > > > >
Thanks. Stanley Chu
| |