lkml.org 
[lkml]   [2018]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 5/8] staging: rtl8192u: Use %s and __func__ instead of hardcoded string - Style
On Tue, Jun 26, 2018 at 11:56:24AM +0800, Greg KH wrote:
> On Sun, Jun 24, 2018 at 04:34:51PM +0100, John Whitmore wrote:
> > Changed a number of hard coded function names to use %s and __func__
> >
> > Mailing list response suggest that there is a better method for debugging
> > using netdev_dbg(). I can't argue with that, but for the moment this change
> > will clear the checkpatch.pl Warning.
> >
> > Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
> > ---
> > drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 12 ++++++------
> > 1 file changed, 6 insertions(+), 6 deletions(-)
>
> Did not apply :(

No worries, can I just ask is that because it should be changed to use
netdev_dbg as was suggested? And should that be across the whole file?

\
 
 \ /
  Last update: 2018-06-27 22:23    [W:0.071 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site