Messages in this thread | | | Date | Wed, 27 Jun 2018 11:01:15 +0200 | From | Miquel Raynal <> | Subject | Re: [PATCH v2] mtd: rawnand: mxc: remove __init qualifier from mxcnd_probe_dt |
| |
Hi Martin,
On Wed, 27 Jun 2018 10:52:37 +0200, Martin Kaiser <martin@kaiser.cx> wrote:
> Using the sysfs unbind, bind nodes, mxcnd_probe and mxcnd_probe_dt can > potentially be called at any time. After the __init functions are cleaned, > mxcnd_probe_dt is no longer available. Calling it anyway causes a crash. > > mxcnd_probe used to be marked as __init, this was removed years ago. > Remove the __init qualifier from from mxcnd_probe_dt as well. > > Fixes: 06f2551 ("mtd: remove use of __devinit")
Nitpick: the Fixes tag should use at least the 12 first characters of the SHA-1 ID, see:
https://www.kernel.org/doc/html/v4.16/process/submitting-patches.html#describe-your-changes
Thanks, Miquèl
| |