Messages in this thread | | | From | Punit Agrawal <> | Subject | Re: [PATCH 1/2] arm64: avoid alloc memory on offline node | Date | Tue, 26 Jun 2018 18:27:01 +0100 |
| |
Jonathan Cameron <jonathan.cameron@huawei.com> writes:
[...]
> > I'll test it when back in the office, but I had a similar issue with > memory only nodes when I moved the SRAT listing for cpus from the 4 > 4th mode to the 3rd node to fake some memory I could hot unplug. > This gave a memory only node for the last node on the system. > > When I instead moved cpus from the 3rd node to the 4th (so the node > with only memory was now in the middle, everything worked). > > Was odd, and I'd been meaning to chase it down but hadn't gotten to it > yet. If I get time I'll put together some test firmwares as see if there > are any other nasty corner cases we aren't handling.
If you get a chance, it'd be really helpful to test reversing the ordering of entries in the SRAT and booting with a restricted NR_CPUS.
This issue was found through code inspection.
Please make sure to use the updated patch from Lorenzo for your tests[0].
[0] https://marc.info/?l=linux-acpi&m=152998665713983&w=2
> > Jonathan > >> >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-kernel@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
| |