Messages in this thread | | | Date | Tue, 26 Jun 2018 10:24:49 +0200 | From | Cornelia Huck <> | Subject | Re: [PATCH] s390/boot: block uncompressed vmlinux booting attempts |
| |
On Tue, 26 Jun 2018 09:30:19 +0200 Christian Borntraeger <borntraeger@de.ibm.com> wrote:
> On 06/25/2018 05:09 PM, Vasily Gorbik wrote: > > Since uncompressed kernel image "vmlinux" elf file is not bootable under > > qemu anymore, add a check which would report that. > > > > Qemu users are encouraged to use bzImage or > > arch/s390/boot/compressed/vmlinux instead. > > > > The check relies on s390 linux entry point ABI definition, which is only > > present in bzImage and arch/s390/boot/compressed/vmlinux. > > > > Signed-off-by: Vasily Gorbik <gor@linux.ibm.com> > Acked-by: Christian Borntraeger <borntraeger@de.ibm.com> > > some proposals regarding the wording below.. > > [...] > > + > > + sclp_early_printk("The linux kernel boot failure: the image is corrupted or not bootable.\n"); > > + sclp_early_printk("Please check that you are using bootable kernel image \"bzImage\".\n"); > > + sclp_early_printk("(or alternatively \"arch/s390/boot/compressed/vmlinux\" image for qemu)\n"); > > What about making this explain things a bit more, e.g. something like > > Linux kernel boot failure: The boot image does not contain all necessary > components (like the entry point and decompressor). The plain vmlinux ELF > file no longer carries all necessary parts for starting up. Please use > bzImage or arch/s390/boot/compressed/vmlinux.
Yes, that sounds good. With the changed message,
Acked-by: Cornelia Huck <cohuck@redhat.com>
| |