lkml.org 
[lkml]   [2018]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH V4 2/4] watchdog: stm32: add pclk feature for stm32mp1
From
Date
On 06/25/2018 05:52 AM, Alexandre Torgue wrote:
> Hi Guenter,
>
>
>>> But you are right I forgot to change stm32f429.dtsi.
>>> If I add a commit for stm32f429.dtsi, it's Ok for you ?
>>>
>>
>> Not really. You are imposing a personal preference on others,
>> and you would make stm32f429.dtsi inconsistent since it doesn't
>> use clock names for anything else.This in turn means that people
>> will have an endless source of irritation since they will need
>> a clock name for this node but not for others.
>
> Why? This kind of implementation depends on each driver. Isn't ?
>
> Or do you mean that if iwdg driver uses this implementation (clock name usage) all nodes inside stm32f429.dtsi should follow the same implementation ?
>
>>
>> You will have to get the arm and DT maintainers to agree on this change.
>
> As this patch makes easier integration of new platform, I agree with Ludovic proposition.
>

Please provide a formal Acked-by:.

Guenter

\
 
 \ /
  Last update: 2018-06-25 15:17    [W:0.063 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site