lkml.org 
[lkml]   [2018]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v3 3/8] staging: rtl8192u: User memset to initialize memory, instead of loop.
    On Sun, Jun 24, 2018 at 6:34 PM, John Whitmore <johnfwhitmore@gmail.com> wrote:
    > Replaced memory initialising loop with memset, as suggested by Andy Shevchenko
    >

    Suggested-by ?

    > Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
    > ---
    > drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 5 +----
    > 1 file changed, 1 insertion(+), 4 deletions(-)
    >
    > diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
    > index 4bfadb49c363..ccb7bdf5ad5d 100644
    > --- a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
    > +++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
    > @@ -742,8 +742,6 @@ void HTConstructRT2RTAggElement(struct ieee80211_device *ieee, u8 *posRT2RTAgg,
    > */
    > static u8 HT_PickMCSRate(struct ieee80211_device *ieee, u8 *pOperateMCS)
    > {
    > - u8 i;
    > -
    > if (!pOperateMCS) {
    > IEEE80211_DEBUG(IEEE80211_DL_ERR, "pOperateMCS can't be null in HT_PickMCSRate()\n");
    > return false;
    > @@ -756,8 +754,7 @@ static u8 HT_PickMCSRate(struct ieee80211_device *ieee, u8 *pOperateMCS)
    > //legacy rate routine handled at selectedrate
    >
    > //no MCS rate
    > - for (i = 0; i <= 15; i++)
    > - pOperateMCS[i] = 0;
    > + memset(pOperateMCS, 0, 16);
    > break;
    >
    > case IEEE_N_24G: //assume CCK rate ok
    > --
    > 2.17.1
    >



    --
    With Best Regards,
    Andy Shevchenko

    \
     
     \ /
      Last update: 2018-06-25 11:07    [W:2.251 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site