lkml.org 
[lkml]   [2018]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH tip/core/rcu 11/27] rcu: Remove "inline" from panic_on_rcu_stall() and rcu_blocking_is_gp()
    Date
    These functions are in kernel/rcu/tree.c, which is not an include file,
    so there is no problem dropping the "inline", especially given that these
    functions are nowhere near a fastpath. This commit therefore delegates
    the inlining decision to the compiler by dropping the "inline".

    Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
    ---
    kernel/rcu/tree.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
    index 98f51157f735..11fb6542b9d4 100644
    --- a/kernel/rcu/tree.c
    +++ b/kernel/rcu/tree.c
    @@ -1342,7 +1342,7 @@ static void rcu_stall_kick_kthreads(struct rcu_state *rsp)
    }
    }

    -static inline void panic_on_rcu_stall(void)
    +static void panic_on_rcu_stall(void)
    {
    if (sysctl_panic_on_rcu_stall)
    panic("RCU Stall\n");
    @@ -3078,7 +3078,7 @@ EXPORT_SYMBOL_GPL(kfree_call_rcu);
    * when there was in fact only one the whole time, as this just adds
    * some overhead: RCU still operates correctly.
    */
    -static inline int rcu_blocking_is_gp(void)
    +static int rcu_blocking_is_gp(void)
    {
    int ret;

    --
    2.17.1
    \
     
     \ /
      Last update: 2018-06-26 02:34    [W:4.207 / U:0.140 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site