lkml.org 
[lkml]   [2018]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 49/52] HID: wacom: Correct logical maximum Y for 2nd-gen Intuos Pro large
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Jason Gerecke <killertofu@gmail.com>

    commit d471b6b22d37bf9928c6d0202bdaaf76583b8b61 upstream.

    The HID descriptor for the 2nd-gen Intuos Pro large (PTH-860) contains
    a typo which defines an incorrect logical maximum Y value. This causes
    a small portion of the bottom of the tablet to become unusable (both
    because the area is below the "bottom" of the tablet and because
    'wacom_wac_event' ignores out-of-range values). It also results in a
    skewed aspect ratio.

    To fix this, we add a quirk to 'wacom_usage_mapping' which overwrites
    the data with the correct value.

    Signed-off-by: Jason Gerecke <jason.gerecke@wacom.com>
    CC: stable@vger.kernel.org # v4.10+
    Signed-off-by: Jiri Kosina <jkosina@suse.cz>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/hid/wacom_sys.c | 8 ++++++++
    1 file changed, 8 insertions(+)

    --- a/drivers/hid/wacom_sys.c
    +++ b/drivers/hid/wacom_sys.c
    @@ -284,6 +284,14 @@ static void wacom_usage_mapping(struct h
    }
    }

    + /* 2nd-generation Intuos Pro Large has incorrect Y maximum */
    + if (hdev->vendor == USB_VENDOR_ID_WACOM &&
    + hdev->product == 0x0358 &&
    + WACOM_PEN_FIELD(field) &&
    + wacom_equivalent_usage(usage->hid) == HID_GD_Y) {
    + field->logical_maximum = 43200;
    + }
    +
    switch (usage->hid) {
    case HID_GD_X:
    features->x_max = field->logical_maximum;

    \
     
     \ /
      Last update: 2018-06-24 18:16    [W:3.208 / U:0.280 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site