lkml.org 
[lkml]   [2018]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 7/8] staging: rtl8192u: Correct if statement - Coding Style
From
Date
On Sun, 2018-06-24 at 16:34 +0100, John Whitmore wrote:
> Corrected the coding style of if statement.
[]
> diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
[]
> @@ -732,7 +732,7 @@ void HTConstructRT2RTAggElement(struct ieee80211_device *ieee, u8 *posRT2RTAgg,
> section of code.
> if(IS_UNDER_11N_AES_MODE(Adapter))
> {
> - posRT2RTAgg->Octet[5] |=RT_HT_CAP_USE_AMPDU;
> + posRT2RTAgg->Octet[5] |= RT_HT_CAP_USE_AMPDU;
> }else
> {
> posRT2RTAgg->Octet[5] &= 0xfb;

Rather than doing individual patches for each line
with a whitespace issue, I think it'd be better to
do a single driver wide patch.

Perhaps use a tool like:

$ git ls-files drivers/staging/rtl8192u |
xargs ./scripts/checkpatch.pl -f --fix-inplace --types=spacing

where:

$ git diff -w drivers/staging/rtl8192u/

should not show a single difference.

Then compile and commit that as a single patch with
something like "use a more typical spacing style"
as the commit message.

\
 
 \ /
  Last update: 2018-06-24 18:00    [W:0.129 / U:5.844 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site