lkml.org 
[lkml]   [2018]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V7 00/41] Intel(R) Resource Director Technology Cache Pseudo-Locking enabling
On Sun, 24 Jun 2018, David Howells wrote:

> Thomas Gleixner <tglx@linutronix.de> wrote:
>
> > - Stick the struct into the local header file and not at some random place in
> > the source.
>
> Why? It's only used in that one file. There doesn't seem to be any
> particular need to share it around.

It's not in a global header. It's a local header exactly to stick stuff
like that into it.

> > - Get rid of the fugly camel case
>
> It's not camel case. It's the name of the option it's encoding. But if it
> makes you happy...

Well, the option name slipped through, but that doesn't make an excuse for
making the struct member equally ugly.

Thanks,

tglx

\
 
 \ /
  Last update: 2018-06-24 02:29    [W:0.401 / U:0.364 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site