lkml.org 
[lkml]   [2018]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v4 2/7] x86/fsgsbase/64: Make ptrace read FS/GS base accurately
    On Wed, 20 Jun 2018, Chang S. Bae wrote:

    > From: Andy Lutomirski <luto@kernel.org>
    >
    > ptrace can read FS/GS base using the register access API
    > (PTRACE_PEEKUSER, etc) or PTRACE_ARCH_PRCTL. Make both of these
    > mechanisms return the actual FS/GS base.

    That's the 'BUG' fix, right? Ok, not something which needs to be urgently
    backported it seems. It's surely a correctness issue, which improved
    debugability, but surely not something crucial.

    So the right ordering of the patches is:

    1) Introduce task_seg_base() as a standalong patch w/o using it.

    2) Add the new fsgs helpers and use task_seg_base() right away instead
    of adding this misleading 'preserve bug' comment just to remove it
    one patch later.

    .....

    Thanks,

    tglx

    \
     
     \ /
      Last update: 2018-06-22 16:38    [W:4.298 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site