lkml.org 
[lkml]   [2018]   [Jun]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 2/6] ext4: use 64-bit timestamps for mmp_time
Date
On Jun 20, 2018, at 9:32 AM, Arnd Bergmann <arnd@arndb.de> wrote:
>
> The mmp_time field is 64 bits wide, which is good, but calling
> get_seconds() results in a 32-bit value on 32-bit architectures. Using
> ktime_get_real_seconds() instead returns 64 bits everywhere.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Andreas Dilger <adilger@dilger.ca>

> ---
> fs/ext4/mmp.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/ext4/mmp.c b/fs/ext4/mmp.c
> index 27b9a76a0dfa..39da4eb48361 100644
> --- a/fs/ext4/mmp.c
> +++ b/fs/ext4/mmp.c
> @@ -147,7 +147,7 @@ static int kmmpd(void *data)
>
> mmp_block = le64_to_cpu(es->s_mmp_block);
> mmp = (struct mmp_struct *)(bh->b_data);
> - mmp->mmp_time = cpu_to_le64(get_seconds());
> + mmp->mmp_time = cpu_to_le64(ktime_get_real_seconds());
> /*
> * Start with the higher mmp_check_interval and reduce it if
> * the MMP block is being updated on time.
> @@ -165,7 +165,7 @@ static int kmmpd(void *data)
> seq = 1;
>
> mmp->mmp_seq = cpu_to_le32(seq);
> - mmp->mmp_time = cpu_to_le64(get_seconds());
> + mmp->mmp_time = cpu_to_le64(ktime_get_real_seconds());
> last_update_time = jiffies;
>
> retval = write_mmp_block(sb, bh);
> @@ -244,7 +244,7 @@ static int kmmpd(void *data)
> * Unmount seems to be clean.
> */
> mmp->mmp_seq = cpu_to_le32(EXT4_MMP_SEQ_CLEAN);
> - mmp->mmp_time = cpu_to_le64(get_seconds());
> + mmp->mmp_time = cpu_to_le64(ktime_get_real_seconds());
>
> retval = write_mmp_block(sb, bh);
>
> --
> 2.9.0
>


Cheers, Andreas





[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2018-06-21 19:20    [W:0.117 / U:0.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site