Messages in this thread | | | Date | Thu, 21 Jun 2018 13:00:02 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCHv3 09/18] atomics/alpha: define atomic64_fetch_add_unless() |
| |
* Mark Rutland <mark.rutland@arm.com> wrote:
> On Mon, Jun 18, 2018 at 04:54:40PM +0100, Will Deacon wrote: > > On Mon, Jun 18, 2018 at 11:19:10AM +0100, Mark Rutland wrote: > > > /** > > > - * atomic64_add_unless - add unless the number is a given value > > > + * atomic64_fetch_add_unless - add unless the number is a given value > > > * @v: pointer of type atomic64_t > > > * @a: the amount to add to v... > > > * @u: ...unless v is equal to u. > > > * > > > * Atomically adds @a to @v, so long as it was not @u. > > > - * Returns true iff @v was not @u. > > > + * Returns the old value of @v. > > > */ > > > -static __inline__ int atomic64_add_unless(atomic64_t *v, long a, long u) > > > +static __inline__ int atomic64_fetch_add_unless(atomic64_t *v, long a, long u) > > > > Whoops; yes. > > From a scan of the series, I messed that up in the instrumentation, too, > but the rest sems fine. > > I'll fix those up and push out an updated branch.
Please send out an updated series via email as well once it has all settled down.
Thanks!
Ingo
| |