Messages in this thread | | | Date | Wed, 20 Jun 2018 14:44:36 +0900 (KST) | Subject | Re: [PATCH] net: nixge: Add __packed attribute to DMA descriptor struct | From | David Miller <> |
| |
From: Moritz Fischer <mdf@kernel.org> Date: Tue, 19 Jun 2018 09:54:53 -0700
> @@ -122,7 +122,7 @@ struct nixge_hw_dma_bd { > u32 sw_id_offset; > u32 reserved5; > u32 reserved6; > -}; > +} __packed;
As I understand it, based upon your replies to Florian, this bug doesn't even show up with the current code. The problem only happens with some 64-bit changes you are working on.
So, the change is not valid right now.
And for the 64-bit changes, I agree with Florian that you should adjust your implementation so that this __packed dance isn't necessary and that you can avoid some MMIOs as well.
Thanks.
| |