lkml.org 
[lkml]   [2018]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] staging: pi433: fix race condition in pi433_open
On Tue, Jun 19, 2018 at 10:33:26PM -0400, Hugo Lefeuvre wrote:
> @@ -1178,6 +1152,11 @@ static int pi433_probe(struct spi_device *spi)
> device->tx_active = false;
> device->interrupt_rx_allowed = false;
>
> + /* init rx buffer */
> + device->rx_buffer = kmalloc(MAX_MSG_SIZE, GFP_KERNEL);
> + if (!device->rx_buffer)
> + return -ENOMEM;

We need to free device.

> +
> /* init wait queues */
> init_waitqueue_head(&device->tx_wait_queue);
> init_waitqueue_head(&device->rx_wait_queue);
> @@ -1280,6 +1259,7 @@ static int pi433_probe(struct spi_device *spi)
> minor_failed:
> free_gpio(device);
> GPIO_failed:
> + kfree(device->rx_buffer);
> kfree(device);
>
> return retval;

regards,
dan carpenter

\
 
 \ /
  Last update: 2018-06-20 11:11    [W:0.052 / U:0.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site