Messages in this thread | | | Subject | Re: [PATCH] clk: davinci: cfgchip: testing the wrong variable | From | David Lechner <> | Date | Sat, 2 Jun 2018 09:33:00 -0500 |
| |
On 06/02/2018 02:52 AM, Dan Carpenter wrote: > There is a copy and paste bug here. We should be testing "usb1" instead > of "usb0". > > Fixes: 58e1e2d2cd89 ("clk: davinci: cfgchip: Add TI DA8XX USB PHY clocks") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > diff --git a/drivers/clk/davinci/da8xx-cfgchip.c b/drivers/clk/davinci/da8xx-cfgchip.c > index c971111d2601..20a120aa147e 100644 > --- a/drivers/clk/davinci/da8xx-cfgchip.c > +++ b/drivers/clk/davinci/da8xx-cfgchip.c > @@ -672,7 +672,7 @@ static int of_da8xx_usb_phy_clk_init(struct device *dev, struct regmap *regmap) > > usb1 = da8xx_cfgchip_register_usb1_clk48(dev, regmap); > if (IS_ERR(usb1)) { > - if (PTR_ERR(usb0) == -EPROBE_DEFER) > + if (PTR_ERR(usb1) == -EPROBE_DEFER) > return -EPROBE_DEFER; > > dev_warn(dev, "Failed to register usb1_clk48 (%ld)\n", >
Reviewed-by: David Lechner <david@lechnology.com>
| |