lkml.org 
[lkml]   [2018]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC PATCH] ARM: Use logical or instead of addition for badr address calculation
    On Tue, Jun 19, 2018 at 03:35:07PM +0200, Ard Biesheuvel wrote:
    > >>
    > >> + /* this needs to be a separate macro or \@ does not work correctly
    > >> */
    > >> + .macro __badr, c, rd, sym
    > >> + .eqv .Lsym\@, \sym
    > >> + adr\c \rd, .Lsym\@ + 1
    > >
    > >
    > > Wild shot, but the following works for me.
    > >
    > > .eqv .Lsym\@, \sym + 1
    > > adr\c \rd, .Lsym\@
    > >
    > > Does it make sense ?
    > >
    >
    > Interesting. Do you mean this works with your 2.30 binutils that
    > triggers the original issue?
    >

    Yes, it does. It is also the solution used for some graphics libraries,
    though of course now I don't find the link anymore.

    Guess this is going nowhere given Russell's response, so I'll just
    live with it, like obviously everyone else does already. I built
    a toolchain using gcc 7.3.0 and binutils 2.28.1 which "solves"
    the problem for me.

    Guenter

    \
     
     \ /
      Last update: 2018-06-19 19:25    [W:2.820 / U:0.632 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site