Messages in this thread | | | Subject | Re: [PATCH v2 3/8] mfd: cros_ec: Add or fix SPDX-License-Identifier in all files. | From | Enric Balletbo i Serra <> | Date | Tue, 19 Jun 2018 11:05:05 +0200 |
| |
Hi Lee,
On 18/06/18 08:37, Lee Jones wrote: > On Tue, 05 Jun 2018, Enric Balletbo i Serra wrote: > >> And get rid of the license text that is no longer necessary. Also fix >> the license as sometimes doesn't match what the header with the value in >> the MODULE_LICENSE macro. Assuming that the desired license is GPL-2.0+, >> all the files are updated to this license version. >> >> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> >> --- >> >> Changes in v2: None >> >> drivers/mfd/cros_ec.c | 26 ++++++++------------------ >> drivers/mfd/cros_ec_dev.c | 23 +++++------------------ >> drivers/mfd/cros_ec_dev.h | 16 ++-------------- >> drivers/mfd/cros_ec_i2c.c | 18 ++++-------------- >> drivers/mfd/cros_ec_spi.c | 20 +++++--------------- >> include/linux/mfd/cros_ec.h | 10 +--------- >> include/linux/mfd/cros_ec_commands.h | 10 +--------- >> include/linux/mfd/cros_ec_lpc_mec.h | 14 +++----------- >> include/linux/mfd/cros_ec_lpc_reg.h | 14 +++----------- >> 9 files changed, 32 insertions(+), 119 deletions(-) >> >> diff --git a/drivers/mfd/cros_ec.c b/drivers/mfd/cros_ec.c >> index 58e05069163e..5b6a1c541543 100644 >> --- a/drivers/mfd/cros_ec.c >> +++ b/drivers/mfd/cros_ec.c >> @@ -1,21 +1,11 @@ >> -/* >> - * ChromeOS EC multi-function device >> - * >> - * Copyright (C) 2012 Google, Inc >> - * >> - * This software is licensed under the terms of the GNU General Public >> - * License version 2, as published by the Free Software Foundation, and >> - * may be copied, distributed, and modified under those terms. >> - * >> - * This program is distributed in the hope that it will be useful, >> - * but WITHOUT ANY WARRANTY; without even the implied warranty of >> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> - * GNU General Public License for more details. >> - * >> - * The ChromeOS EC multi function device is used to mux all the requests >> - * to the EC device for its multiple features: keyboard controller, >> - * battery charging and regulator control, firmware update. >> - */ >> +// SPDX-License-Identifier: GPL-2.0+ >> +// ChromeOS EC multi-function device. >> +// >> +// Copyright (C) 2012 Google, Inc >> +// >> +// The ChromeOS EC multi function device is used to mux all the requests >> +// to the EC device for its multiple features: keyboard controller, >> +// battery charging and regulator control, firmware update. > > I must admit I haven't seen a great many patches like this. Is C++ > comments for the SPDX header *and* the Copyright text the done thing > now then? >
There is a bit of mess here, as per documentation, it is clear that the SPDX tag for .c files should go in C++ style, but for the copyright notice is not clear and there are differences between subsystems.
Seems that putting everything as // is Linus Torvalds' preferred style [1] but other maintainers want the copyright in c-style. If you see current status in the kernel both styles are present.
[1] https://lkml.org/lkml/2017/11/25/133
Best regards, Enric
| |