Messages in this thread | | | Subject | Re: Constant ata messages on console with commit 28361c403683 ("libata: add extra internal command") (was Re: [GIT PULL 2/2] libata changes for v4.18-rc1) | From | Jens Axboe <> | Date | Tue, 19 Jun 2018 17:38:34 -0600 |
| |
On 6/19/18 5:35 PM, Michael Ellerman wrote: > Jens Axboe <axboe@kernel.dk> writes: >> On 6/19/18 1:29 AM, Michael Ellerman wrote: >>> Jens Axboe <axboe@kernel.dk> writes: >>>> On 6/18/18 1:33 AM, Michael Ellerman wrote: >>>>> Tejun Heo <tj@kernel.org> writes: >>>>> ... >>>>>> Jens Axboe (10): >>>>>> libata: introduce notion of separate hardware tags >>>>>> libata: convert core and drivers to ->hw_tag usage >>>>>> libata: bump ->qc_active to a 64-bit type >>>>>> libata: use ata_tag_internal() consistently >>>>>> libata: remove assumption that ATA_MAX_QUEUE - 1 is the max >>>>>> sata_nv: set host can_queue count appropriately >>>>>> libata: add extra internal command >>>>> >>>>> Replying here because I can't find the original mail. >>>>> >>>>> The above commit is causing one of my machines to constantly spew ata >>>>> messages on the console, according to bisect: >>>>> >>>>> # first bad commit: [28361c403683c2b00d4f5e76045f3ccd299bf99d] libata: add extra internal command >>>>> >>>>> To get it to boot I have to also apply: >>>>> >>>>> 88e10092f6a6 ("sata_fsl: use the right type for tag bitshift") >>>>> >>>>> >>>>> The system boots OK and seems fine, except that it's just printing >>>>> multiple of these per second: >>>>> >>>>> ata2: Signature Update detected @ 0 msecs >>>>> ata2: SATA link up 1.5 Gbps (SStatus 113 SControl 300) >>>>> ata2.00: configured for UDMA/100 >>>>> ata2: Signature Update detected @ 0 msecs >>>>> ata2: SATA link up 1.5 Gbps (SStatus 113 SControl 300) >>>>> ata2.00: configured for UDMA/100 >>>>> ata2: Signature Update detected @ 0 msecs >>>>> ata2: SATA link up 1.5 Gbps (SStatus 113 SControl 300) >>>>> ata2.00: configured for UDMA/100 >>>>> ata2: Signature Update detected @ 0 msecs >>>>> ata2: SATA link up 1.5 Gbps (SStatus 113 SControl 300) >>>>> ata2.00: configured for UDMA/100 >>>>> ata2: Signature Update detected @ 0 msecs > ... >> >> Actually, just try this one on top of current -git. > > Yep that fixes it. > > No more message spam, and when I try to mount sr0 it says "no medium". > > I'll have to go into the office to actually put a disc in the drive > to check it's really working, but it seems likely. > > Thanks for debugging it, here's a tested-by if you like: > > Tested-by: Michael Ellerman <mpe@ellerman.id.au>
Thanks, but I packaged it a little differently, see the other series I CC'ed you on. It'll work the same, though. It's in Tejun's tree now, so should end up with Linus some time this week I think.
Thanks for reporting and testing the fix!
-- Jens Axboe
| |