lkml.org 
[lkml]   [2018]   [Jun]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 086/189] RDMA/iwpm: fix memory leak on map_info
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Colin Ian King <colin.king@canonical.com>

    [ Upstream commit f96416cea7bce9afe619c15e87fced70f93f9098 ]

    In the cases where iwpm_hash_bucket is NULL and where function
    get_mapinfo_hash_bucket returns NULL then the map_info is never added
    to hash_bucket_head and hence there is a leak of map_info. Fix this
    by nullifying hash_bucket_head and if that is null we know that
    that map_info was not added to hash_bucket_head and hence map_info
    should be free'd.

    Detected by CoverityScan, CID#1222481 ("Resource Leak")

    Fixes: 30dc5e63d6a5 ("RDMA/core: Add support for iWARP Port Mapper user space service")
    Signed-off-by: Colin Ian King <colin.king@canonical.com>
    Signed-off-by: Doug Ledford <dledford@redhat.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/infiniband/core/iwpm_util.c | 5 ++++-
    1 file changed, 4 insertions(+), 1 deletion(-)

    --- a/drivers/infiniband/core/iwpm_util.c
    +++ b/drivers/infiniband/core/iwpm_util.c
    @@ -114,7 +114,7 @@ int iwpm_create_mapinfo(struct sockaddr_
    struct sockaddr_storage *mapped_sockaddr,
    u8 nl_client)
    {
    - struct hlist_head *hash_bucket_head;
    + struct hlist_head *hash_bucket_head = NULL;
    struct iwpm_mapping_info *map_info;
    unsigned long flags;
    int ret = -EINVAL;
    @@ -142,6 +142,9 @@ int iwpm_create_mapinfo(struct sockaddr_
    }
    }
    spin_unlock_irqrestore(&iwpm_mapinfo_lock, flags);
    +
    + if (!hash_bucket_head)
    + kfree(map_info);
    return ret;
    }


    \
     
     \ /
      Last update: 2018-06-18 11:02    [W:5.734 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site