Messages in this thread | | | From | Doug Anderson <> | Date | Mon, 18 Jun 2018 12:54:07 -0700 | Subject | Re: [PATCH v11 04/10] drivers: qcom: rpmh: add RPMH helper functions |
| |
Hi,
On Mon, Jun 18, 2018 at 12:06 PM, Lina Iyer <ilina@codeaurora.org> wrote: > On Mon, Jun 18 2018 at 12:33 -0600, Doug Anderson wrote: >> >> Lina, >> >> On Mon, Jun 18, 2018 at 9:39 AM, Lina Iyer <ilina@codeaurora.org> wrote: >>>> >>>> +/** >>>> * struct rsc_drv: the Direct Resource Voter (DRV) of the >>>> * Resource State Coordinator controller (RSC) >>>> * >>>> @@ -52,6 +78,7 @@ struct tcs_group { >>>> * @tcs: TCS groups >>>> * @tcs_in_use: s/w state of the TCS >>>> * @lock: synchronize state of the controller >>>> + * @ctrl: controller to handle cases like batch requests >>> >>> >>> This is not only for batch requests. >>> This is handle to the DRV's client. @client might be a better name than >>> @ctrlr. >> >> >> The name "ctrlr" also matches the name of the structure. Are you >> suggesting also renaming "struct rpmh_ctrlr" to "struct rpmh_client", >> or you think they should be different names? >> > Just the name of the variable. I was just a nice to have. I wouldn't > block for this though. > > I also got a couple Bot reported issues on this and the previous > revision that I have sent to Raju. He is planning to the post the v12 > tomorrow his time after fixing them. If you can wait until then, I would > recommend picking up the v12 instead of this.
OK, if Raju can post the v12 tomorrow his time then that sounds like a great plan to me. While you're at it, I noticed that checkpatch yelled about a few lines that were > 80 characters long for no good reason. Those would be nice to fix too.
-Doug
| |