lkml.org 
[lkml]   [2018]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v1 4/6] perf: Allow using AUX data in perf samples
    On Tue, Jun 12, 2018 at 10:51:15AM +0300, Alexander Shishkin wrote:
    > @@ -416,6 +418,7 @@ struct perf_event_attr {
    > __u32 aux_watermark;
    > __u16 sample_max_stack;
    > __u16 __reserved_2; /* align to __u64 */
    > + __u64 aux_sample_size;
    > };

    Do we really need a __u64 for that? I can see how that __u16 hole might
    be too small (512K), but do we really need >4G 'samples' ?

    \
     
     \ /
      Last update: 2018-06-14 21:30    [W:5.045 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site