lkml.org 
[lkml]   [2018]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 01/14] ubi: fastmap: Read PEB numbers more carefully
Date
Am Donnerstag, 14. Juni 2018, 03:04:40 CEST schrieb kbuild test robot:
> Hi Richard,
>
> I love your patch! Perhaps something to improve:
>
> [auto build test WARNING on mtd/master]
> [also build test WARNING on v4.17 next-20180613]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url: https://github.com/0day-ci/linux/commits/Richard-Weinberger/ubi-Fastmap-updates/20180614-052830
> base: git://git.infradead.org/linux-mtd.git master
> reproduce:
> # apt-get install sparse
> make ARCH=x86_64 allmodconfig
> make C=1 CF=-D__CHECK_ENDIAN__
>
>
> sparse warnings: (new ones prefixed by >>)
>
> >> drivers/mtd/ubi/fastmap.c:110:14: sparse: incorrect type in assignment (different base types) @@ expected restricted __be32 [usertype] pnum @@ got [usertype] pnum @@
> drivers/mtd/ubi/fastmap.c:110:14: expected restricted __be32 [usertype] pnum
> drivers/mtd/ubi/fastmap.c:110:14: got unsigned int
> >> drivers/mtd/ubi/fastmap.c:111:13: sparse: restricted __be32 degrades to integer
> >> drivers/mtd/ubi/fastmap.c:112:27: sparse: incorrect type in assignment (different base types) @@ expected int [signed] <noident> @@ got restricted __be3int [signed] <noident> @@
> drivers/mtd/ubi/fastmap.c:112:27: expected int [signed] <noident>
> drivers/mtd/ubi/fastmap.c:112:27: got restricted __be32 [usertype] pnum
> drivers/mtd/ubi/fastmap.c:116:13: sparse: restricted __be32 degrades to integer
> drivers/mtd/ubi/fastmap.c:116:25: sparse: restricted __be32 degrades to integer
> drivers/mtd/ubi/fastmap.c:121:27: sparse: incorrect type in assignment (different base types) @@ expected int [signed] <noident> @@ got restricted __be3int [signed] <noident> @@
> drivers/mtd/ubi/fastmap.c:121:27: expected int [signed] <noident>
> drivers/mtd/ubi/fastmap.c:121:27: got restricted __be32 [usertype] pnum
> drivers/mtd/ubi/fastmap.c:604:23: sparse: incorrect type in assignment (different base types) @@ expected unsigned long long [unsigned] max_sqnum @@ got nsigned long long [unsigned] max_sqnum @@
> drivers/mtd/ubi/fastmap.c:604:23: expected unsigned long long [unsigned] max_sqnum
> drivers/mtd/ubi/fastmap.c:604:23: got restricted __be64 [usertype] sqnum
> drivers/mtd/ubi/fastmap.c:1075:17: sparse: incorrect type in assignment (different base types) @@ expected restricted __be32 [usertype] tmp_crc @@ got [usertype] tmp_crc @@
> drivers/mtd/ubi/fastmap.c:1075:17: expected restricted __be32 [usertype] tmp_crc
> drivers/mtd/ubi/fastmap.c:1075:17: got unsigned int
> drivers/mtd/ubi/fastmap.c:1077:13: sparse: incorrect type in assignment (different base types) @@ expected restricted __be32 [usertype] crc @@ got [usertype] crc @@
> drivers/mtd/ubi/fastmap.c:1077:13: expected restricted __be32 [usertype] crc
> drivers/mtd/ubi/fastmap.c:1077:13: got unsigned int
> drivers/mtd/ubi/fastmap.c:1086:22: sparse: incorrect type in assignment (different base types) @@ expected restricted __be64 [usertype] sqnum @@ got unsigned lonrestricted __be64 [usertype] sqnum @@
> drivers/mtd/ubi/fastmap.c:1086:22: expected restricted __be64 [usertype] sqnum
> drivers/mtd/ubi/fastmap.c:1086:22: got unsigned long long [unsigned] [assigned] sqnum
>
> vim +110 drivers/mtd/ubi/fastmap.c
>
> 103
> 104 static bool read_pnum(struct ubi_device *ubi, struct ubi_attach_info *ai,
> 105 __be32 pnum, int *out_pnum)
> 106 {
> 107 int ret = true;
> 108 int max_pnum = ubi->peb_count;
> 109
> > 110 pnum = be32_to_cpu(pnum);
> > 111 if (pnum == UBI_UNKNOWN) {
> > 112 *out_pnum = pnum;
> 113 goto out;
> 114 }

Okay, let's use a new variable of type int instead of reusing pnum.

Thanks,
//richard

\
 
 \ /
  Last update: 2018-06-14 08:24    [W:0.073 / U:2.148 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site