lkml.org 
[lkml]   [2018]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.16 19/43] usb: gadget: udc: renesas_usb3: fix double phy_put()
    Date
    4.16-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

    commit 8223b2f89ca63e203dcb54148e30d94979f17b0b upstream.

    This patch fixes an issue that this driver cause double phy_put()
    calling. This driver must not call phy_put() in the remove because
    the driver calls devm_phy_get() in the probe.

    Fixes: 279d4bc64060 ("usb: gadget: udc: renesas_usb3: add support for generic phy")
    Cc: <stable@vger.kernel.org> # v4.15+
    Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
    Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
    Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/usb/gadget/udc/renesas_usb3.c | 2 --
    1 file changed, 2 deletions(-)

    --- a/drivers/usb/gadget/udc/renesas_usb3.c
    +++ b/drivers/usb/gadget/udc/renesas_usb3.c
    @@ -2408,8 +2408,6 @@ static int renesas_usb3_remove(struct pl
    renesas_usb3_dma_free_prd(usb3, &pdev->dev);

    __renesas_usb3_ep_free_request(usb3->ep0_req);
    - if (usb3->phy)
    - phy_put(usb3->phy);
    pm_runtime_disable(&pdev->dev);

    return 0;

    \
     
     \ /
      Last update: 2018-06-14 16:46    [W:4.136 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site