lkml.org 
[lkml]   [2018]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2] scsi: bfa: add error handling for pci_iomap
On Thu, Jun 14, 2018 at 2:57 PM, Zhouyang Jia <jiazhouyang09@gmail.com> wrote:
> When pci_iomap fails, the lack of error-handling code may
> cause unexpected results.

What results?
How had you tested it?

> This patch adds error-handling code after calling pci_iomap.

> + if (bfad->pci_bar2_kva == NULL) {

> + printk(KERN_ERR "Fail to map bar2\n");

pr_err() ?

> + goto out_unmap_bar0;
> + }

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2018-06-14 14:01    [W:0.054 / U:11.552 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site