lkml.org 
[lkml]   [2018]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v4] staging: comedi: Improved readability of function comedi_nsamples_left.
From
Date
On 13/06/18 20:05, Dan Carpenter wrote:
> On Wed, Jun 13, 2018 at 08:26:43PM +0200, Chris Opperman wrote:
>> Hi Dan/Ian,
>>
>> Noted your comments regarding additional text, thanks! Just curious whether
>> the "scissors" format given at the link below is valid?
>>
>> https://kernelnewbies.org/PatchTipsAndTricks
>>
>> It is given as an alternative to placing additional text below the
>> cut-off line.
>>
>
> Try it yourself. Save your email as email.txt and then
> `cat email.txt | git am` and then review the patch with git log -p.
>
> I've seen people do the scissors thing, but I assume the maintainer has
> to hand edit the log which we refuse to do.

It can be done automatically with the git am -c or --scissors option, or
by setting mailinfo.scissors to true in the git config. But since the
use of these special scissors lines is not documented in
Documentation/process/submitting-patches.rst, I don't think it is safe
to assume that no manual intervention would be required by the
maintainer to deal with it.

I wonder where the "scissors" advice on the kernelnewbies page came from?

--
-=( Ian Abbott <abbotti@mev.co.uk> || Web: www.mev.co.uk )=-
-=( MEV Ltd. is a company registered in England & Wales. )=-
-=( Registered number: 02862268. Registered address: )=-
-=( 15 West Park Road, Bramhall, STOCKPORT, SK7 3JZ, UK. )=-

\
 
 \ /
  Last update: 2018-06-14 13:09    [W:0.046 / U:5.380 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site