Messages in this thread | | | From | Leonard Crestez <> | Subject | Re: [PATCH 1/2] ARM: dts: imx6qdl-sabreauto: Add sensors | Date | Thu, 14 Jun 2018 10:17:20 +0000 |
| |
On Thu, 2018-06-07 at 14:07 -0300, Fabio Estevam wrote: > Hi Leonard, > > On Thu, Jun 7, 2018 at 2:00 PM, Leonard Crestez <leonard.crestez@nxp.com> wrote: > > > + > > + isl29023@44 { > > According to Devicetree Specification v0.2 document: > > "The name of a node should be somewhat generic, reflecting the function > of the device and not its precise programming model." > > So you could write: > > light-sensor@44
Ok, will fix in v2.
Should I also assign a label, like "isl29023: light-sensor@44"? I couldn't find any recommendation on this.
There are no immediate uses for a label but this practice is very common. Having labels allows creating minor board variants with reduced churn in the base dts so it seems good.
-- Regards, Leonard | |