lkml.org 
[lkml]   [2018]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 1/2] ARM: dts: imx6qdl-sabreauto: Add sensors
    Date
    On Thu, 2018-06-07 at 14:07 -0300, Fabio Estevam wrote:
    > Hi Leonard,
    >
    > On Thu, Jun 7, 2018 at 2:00 PM, Leonard Crestez <leonard.crestez@nxp.com> wrote:
    >
    > > +
    > > + isl29023@44 {
    >
    > According to Devicetree Specification v0.2 document:
    >
    > "The name of a node should be somewhat generic, reflecting the function
    > of the device and not its precise programming model."
    >
    > So you could write:
    >
    > light-sensor@44

    Ok, will fix in v2.

    Should I also assign a label, like "isl29023: light-sensor@44"? I
    couldn't find any recommendation on this.

    There are no immediate uses for a label but this practice is very
    common. Having labels allows creating minor board variants with reduced
    churn in the base dts so it seems good.

    --
    Regards,
    Leonard
    \
     
     \ /
      Last update: 2018-06-14 12:17    [W:4.919 / U:0.492 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site