lkml.org 
[lkml]   [2018]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] PM / core: Fix supplier device runtime PM usage counter imbalance
[...]

> ---
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Subject: [PATCH v2] PM / core: Fix supplier device runtime PM usage counter imbalance
>
> If a device link is added via device_link_add() by the driver of the
> link's consumer device, the supplier's runtime PM usage counter is
> going to be dropped by the pm_runtime_put_suppliers() call in
> driver_probe_device(). However, in that case it is not incremented
> unless the supplier driver is already present and the link is not
> stateless. That leads to a runtime PM usage counter imbalance for
> the supplier device in a few cases.
>
> To prevent that from happening, bump up the supplier runtime
> PM usage counter in device_link_add() for all links with the
> DL_FLAG_PM_RUNTIME flag set that are added at the consumer probe
> time. Use pm_runtime_get_noresume() for that as the callers of
> device_link_add() who want the supplier to be resumed by it are
> expected to pass DL_FLAG_RPM_ACTIVE in flags to it anyway, but
> additionally resume the supplier if the link is added during
> consumer driver probe to retain the existing behavior for the
> callers depending on it.
>
> Fixes: 21d5c57b3726 (PM / runtime: Use device links)
> Reported-by: Ulf Hansson <ulf.hansson@linaro.org>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>

Kind regards
Uffe

> ---
> drivers/base/core.c | 15 +++++++++++----
> 1 file changed, 11 insertions(+), 4 deletions(-)
>
> Index: linux-pm/drivers/base/core.c
> ===================================================================
> --- linux-pm.orig/drivers/base/core.c
> +++ linux-pm/drivers/base/core.c
> @@ -216,6 +216,13 @@ struct device_link *device_link_add(stru
> link->rpm_active = true;
> }
> pm_runtime_new_link(consumer);
> + /*
> + * If the link is being added by the consumer driver at probe
> + * time, balance the decrementation of the supplier's runtime PM
> + * usage counter after consumer probe in driver_probe_device().
> + */
> + if (consumer->links.status == DL_DEV_PROBING)
> + pm_runtime_get_noresume(supplier);
> }
> get_device(supplier);
> link->supplier = supplier;
> @@ -235,12 +242,12 @@ struct device_link *device_link_add(stru
> switch (consumer->links.status) {
> case DL_DEV_PROBING:
> /*
> - * Balance the decrementation of the supplier's
> - * runtime PM usage counter after consumer probe
> - * in driver_probe_device().
> + * Some callers expect the link creation during
> + * consumer driver probe to resume the supplier
> + * even without DL_FLAG_RPM_ACTIVE.
> */
> if (flags & DL_FLAG_PM_RUNTIME)
> - pm_runtime_get_sync(supplier);
> + pm_runtime_resume(supplier);
>
> link->status = DL_STATE_CONSUMER_PROBE;
> break;
>

\
 
 \ /
  Last update: 2018-06-13 10:28    [W:0.080 / U:0.420 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site