lkml.org 
[lkml]   [2018]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 1/2] gpio: davinci: Shuffle IRQ resource fetching from DT to beginning of probe
From
Date


On Tuesday 12 June 2018 11:15 AM, Alexander Stein wrote:
> On Tuesday, June 12, 2018, 7:27:52 AM CEST Keerthy wrote:
>> This is needed in case of PROBE_DEFER if IRQ resource is not yet ready.
>>
>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>> ---
>> [...]
>> --- a/drivers/gpio/gpio-davinci.c
>> +++ b/drivers/gpio/gpio-davinci.c
>> [...]
>> @@ -168,7 +168,7 @@ static int davinci_gpio_probe(struct platform_device *pdev)
>> {
>> static int ctrl_num, bank_base;
>> int gpio, bank, ret = 0;
>> - unsigned ngpio, nbank;
>> + unsigned ngpio, nbank, bank_irq;
>
> bank_irq should be an int, not unsigned, no?

Yes

>
>> struct davinci_gpio_controller *chips;
>> struct davinci_gpio_platform_data *pdata;
>> struct device *dev = &pdev->dev;
>> @@ -209,6 +209,12 @@ static int davinci_gpio_probe(struct platform_device *pdev)
>> if (IS_ERR(gpio_base))
>> return PTR_ERR(gpio_base);
>>
>> + bank_irq = platform_get_irq(pdev, 0);
>> + if (bank_irq < 0) {
>
> This won't work using an unsigned.

Thanks for catching this. I will correct this in v3.

>
> Best regards,
> Alexander
>
>
>

\
 
 \ /
  Last update: 2018-06-12 07:52    [W:0.032 / U:17.864 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site