Messages in this thread | | | Subject | Re: [PATCH v8 1/2] iommu - Enable debugfs exposure of IOMMU driver internals | From | Gary R Hook <> | Date | Tue, 12 Jun 2018 13:39:04 -0500 |
| |
On 06/05/2018 12:08 PM, Greg KH wrote: > On Tue, Jun 05, 2018 at 12:01:41PM -0500, Gary R Hook wrote: >>>> +/** >>>> + * iommu_debugfs_new_driver_dir - create a vendor directory under debugfs/iommu >>>> + * @vendor: name of the vendor-specific subdirectory to create >>>> + * >>>> + * This function is called by an IOMMU driver to create the top-level debugfs >>>> + * directory for that driver. >>>> + * >>>> + * Return: upon success, a pointer to the dentry for the new directory. >>>> + * NULL in case of failure. >>>> + */ >>>> +struct dentry *iommu_debugfs_new_driver_dir(const char *vendor) >>>> +{ >>>> + struct dentry *d_new; >>>> + >>>> + d_new = debugfs_create_dir(vendor, iommu_debugfs_dir); >>>> + >>>> + return d_new; >>>> +} >>>> +EXPORT_SYMBOL_GPL(iommu_debugfs_new_driver_dir); >>> >>> Why are you wrapping a debugfs call? Why not just export >>> iommu_debugfs_dir instead? >> >> It was a choice, as I stated in my other post. It is not a requirement. >> If you resolutely reject this approach, that's fine. I'll change it, no >> worries. > > Either is fine, but if it stays, it should stay a single line function > :) > > thanks, > > greg k-h >
Then I shall leave it as a black-box function. Single line, of course.
Thank you.
| |