lkml.org 
[lkml]   [2018]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 19/24] qed: Fix mask for physical address in ILT entry
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Shahed Shaikh <shahed.shaikh@cavium.com>

    [ Upstream commit fdd13dd350dda1826579eb5c333d76b14513b812 ]

    ILT entry requires 12 bit right shifted physical address.
    Existing mask for ILT entry of physical address i.e.
    ILT_ENTRY_PHY_ADDR_MASK is not sufficient to handle 64bit
    address because upper 8 bits of 64 bit address were getting
    masked which resulted in completer abort error on
    PCIe bus due to invalid address.

    Fix that mask to handle 64bit physical address.

    Fixes: fe56b9e6a8d9 ("qed: Add module with basic common support")
    Signed-off-by: Shahed Shaikh <shahed.shaikh@cavium.com>
    Signed-off-by: Ariel Elior <ariel.elior@cavium.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/qlogic/qed/qed_cxt.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/net/ethernet/qlogic/qed/qed_cxt.c
    +++ b/drivers/net/ethernet/qlogic/qed/qed_cxt.c
    @@ -43,7 +43,7 @@
    #define ILT_CFG_REG(cli, reg) PSWRQ2_REG_ ## cli ## _ ## reg ## _RT_OFFSET

    /* ILT entry structure */
    -#define ILT_ENTRY_PHY_ADDR_MASK 0x000FFFFFFFFFFFULL
    +#define ILT_ENTRY_PHY_ADDR_MASK (~0ULL >> 12)
    #define ILT_ENTRY_PHY_ADDR_SHIFT 0
    #define ILT_ENTRY_VALID_MASK 0x1ULL
    #define ILT_ENTRY_VALID_SHIFT 52

    \
     
     \ /
      Last update: 2018-06-12 18:54    [W:4.234 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site